Files that changed from the base of the PR and between 0b7c2c6 and 2751fc4.

• apps/services/auth/admin-api/src/app/v2/delegations/test/delegation-admin.spec.ts (1 hunks)
• libs/auth-api-lib/src/lib/delegations/admin/delegation-admin-custom.service.ts (2 hunks)
• libs/auth-api-lib/src/lib/delegations/models/delegation.model.ts (1 hunks)
• libs/services/auth/testing/src/fixtures/types.ts (1 hunks)
• libs/shared/utils/src/lib/errorCodes.ts (1 hunks)

libs/services/auth/testing/src/fixtures/types.ts (1)

40-46: LGTM: Addition of domainName enhances the CreateCustomDelegation type

The addition of the domainName property to the CreateCustomDelegation type is well-implemented and aligns with the PR objectives. This change enhances the delegation management API by allowing the inclusion of domain information in custom delegations.

The modification:

1. Correctly adds domainName to the Pick utility type.
2. Consistently includes domainName in the list of optional properties.
3. Maintains proper TypeScript usage, ensuring type safety.

This localized change improves the type definition without affecting other parts of the file, promoting reusability across different NextJS apps.

libs/auth-api-lib/src/lib/delegations/models/delegation.model.ts (1)

Line range hint 1-180: Adherence to coding guidelines for libs directory

The file adheres to the coding guidelines for the libs directory:

1. It uses TypeScript for defining props and exporting types.
2. The Delegation class is potentially reusable across different NextJS apps.
3. There are no obvious issues with tree-shaking or bundling practices.

To ensure the Delegation model is used correctly across the project, let's verify its usage:

This will help us understand how the Delegation model is used across different parts of the project and ensure its reusability.

✅ Verification successful

Adherence to coding guidelines for libs directory verified.

The Delegation model is correctly implemented and utilized across the project:

• Widely imported and extended by multiple classes.
• Consistently used in type annotations, ensuring type safety.
• No evidence of removed or replaced code affecting functionality.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check usage of Delegation model across the project

# Search for imports of the Delegation model
echo "Searching for imports of the Delegation model:"
rg --type typescript "import.*Delegation.*from.*delegation\.model"

# Search for uses of the Delegation class
echo "\nSearching for uses of the Delegation class:"
rg --type typescript "new Delegation\(" -A 5

Length of output: 389

---

Script:

#!/bin/bash
# Description: Check usage of Delegation model across the project

# Search for imports of the Delegation model
echo "Searching for imports of the Delegation model:"
rg --type ts "import.*Delegation.*from.*delegation\.model"

# Search for uses of the Delegation class
echo "\nSearching for uses of the Delegation class:"
rg --type ts "new Delegation\(" -A 5

Length of output: 2106

---

Script:

#!/bin/bash
# Description: Further check usage patterns of Delegation model

# Search for class inheritance
echo "Searching for classes that extend Delegation:"
rg --type ts "extends Delegation"

# Search for static method calls on Delegation
echo "\nSearching for static method calls on Delegation:"
rg --type ts "Delegation\."

# Search for Delegation used as a type in type annotations
echo "\nSearching for Delegation used as a type in type annotations:"
rg --type ts ": Delegation\b"

Length of output: 15190

apps/services/auth/admin-api/src/app/v2/delegations/test/delegation-admin.spec.ts (1)

342-419: Excellent addition of test cases for duplicate delegation prevention.

These new test cases significantly enhance the robustness of the delegation creation process by covering scenarios where duplicates based on national IDs or reference IDs are attempted. They adhere well to NestJS testing practices and contribute to a more comprehensive test suite.

The additions align well with the PR objectives of implementing checks for existing delegations before insertion. These tests will help ensure that the new error handling for delegation insertion failures works as expected.

libs/auth-api-lib/src/lib/delegations/admin/delegation-admin-custom.service.ts (2)

32-32: Importing Op from sequelize is appropriate for query operators

The addition of Op enables the use of Sequelize operators in queries, which is necessary for the new validation logic.

---

307-319: Query logic correctly checks for existing delegations

The implemented query uses Op.or to check for existing delegations based on either matching fromNationalId and toNationalId, or matching referenceId. This effectively prevents duplicate delegations from being created.

Files that changed from the base of the PR and between 2751fc4 and 3123866.

• libs/portals/admin/delegation-admin/src/constants/errors.ts (1 hunks)
• libs/portals/admin/delegation-admin/src/lib/messages.ts (1 hunks)

libs/portals/admin/delegation-admin/src/constants/errors.ts (1)

15-16: LGTM! The new error codes enhance error handling for delegation creation.

The additions to the FORM_ERRORS constant are well-structured and consistent with the existing pattern. They directly support the PR's objective of improving error handling when checking for existing delegations. The use of TypeScript for defining the record type aligns with the coding guidelines for files in the libs directory.

These centralized error messages contribute to the reusability of components across different NextJS apps, which is a key guideline for code in the libs directory.